Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link case files to torrents and torrents to resume.dat (#2185) and identify settings.dat (#2193) #2187

Merged
merged 25 commits into from
May 15, 2024

Conversation

wladimirleite
Copy link
Member

@wladimirleite wladimirleite commented Apr 28, 2024

Closes #2185.
Closes #2193.

@wladimirleite
Copy link
Member Author

Just finished the changes I had in mind.
I asked the user that is working on a real case in which this PR should be useful to test and I am leaving this as draft until I get his feedback.

@lfcnassif
Copy link
Member

Thank you @wladimirleite!

@wladimirleite wladimirleite marked this pull request as ready for review April 30, 2024 12:38
@wladimirleite
Copy link
Member Author

The user reprocessed his case with this branch, and it worked as expected.

@wladimirleite wladimirleite changed the title Link case files to torrents and torrents to resume.dat (#2185) Link case files to torrents and torrents to resume.dat (#2185) and identify settings.dat (#2193) May 2, 2024
@wladimirleite
Copy link
Member Author

I added changes to #2193 in this same PR.
I had to force push this branch to fix two commits with incorrect issue number.
This should be ready for review now.

@patrickdalla
Copy link
Collaborator

Hi @wladimirleite, @lfcnassif asked me to review this. Could you share your samples?

@wladimirleite
Copy link
Member Author

wladimirleite commented May 3, 2024

Hi @patrickdalla! Sure, I will send you some samples when I am back at my desk.

Copy link
Collaborator

@patrickdalla patrickdalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is good as is (after few corrections). I approve. I only make a last suggestion of putting the name (or path) of the real corresponding item found, as it can be completely different from the name inside the torrent file and a little confusing for the end user to understand the correspondence. But is just a suggestion.

@wladimirleite
Copy link
Member Author

Thanks @patrickdalla!
I will run a last test using a cases with larger videos (that I didn't send to you as there are ~400 GB of data).

@wladimirleite
Copy link
Member Author

I only make a last suggestion of putting the name (or path) of the real corresponding item found, as it can be completely different from the name inside the torrent file and a little confusing for the end user to understand the correspondence. But is just a suggestion.

I added the path of the item found in the case as a new column and made minor formatting changes, to ensure a minimal width for the columns and use a smaller font for confirmed pieces indexes and offset (to save some space and to highlight the 'Yes' in the 'File Found in the Case' column).
image

@wladimirleite
Copy link
Member Author

@lfcnassif, I believe @patrickdalla finished his review.
I just made a couple of minor changes and included French strings introduced in this PR with [TBT]'s.
I don't plan to make any more changes in this PR.

@lfcnassif
Copy link
Member

@lfcnassif, I believe @patrickdalla finished his review.

Sorry @wladimirleite, I forgot this was approved by him. I'll merge this shortly.

and included French strings introduced in this PR with [TBT]'s.

Thank you! I was going to do that.

@lfcnassif lfcnassif merged commit 4258d72 into master May 15, 2024
2 checks passed
@lfcnassif lfcnassif deleted the #2185_LinkTorrents branch May 15, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better detection of Torrent client "settings.dat" Link case files to torrents and torrents to resume.dat
3 participants