-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link case files to torrents and torrents to resume.dat (#2185) and identify settings.dat (#2193) #2187
Conversation
Just finished the changes I had in mind. |
Thank you @wladimirleite! |
The user reprocessed his case with this branch, and it worked as expected. |
dda6330
to
a947873
Compare
a947873
to
3ddf055
Compare
I added changes to #2193 in this same PR. |
Hi @wladimirleite, @lfcnassif asked me to review this. Could you share your samples? |
Hi @patrickdalla! Sure, I will send you some samples when I am back at my desk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it is good as is (after few corrections). I approve. I only make a last suggestion of putting the name (or path) of the real corresponding item found, as it can be completely different from the name inside the torrent file and a little confusing for the end user to understand the correspondence. But is just a suggestion.
Thanks @patrickdalla! |
@lfcnassif, I believe @patrickdalla finished his review. |
Sorry @wladimirleite, I forgot this was approved by him. I'll merge this shortly.
Thank you! I was going to do that. |
Closes #2185.
Closes #2193.