fix: Fix caching mechanisms again

seriaati · Mar 3, 2024 · b239716 · b239716
1 parent 38dc2f8
commit b239716
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/hoyo/enka_client.py b/src/hoyo/enka_client.py
@@ -35,7 +35,10 @@ def _update_cache_with_live_data(self, cache: EnkaCache, live_data: "ShowcaseRes
         live_character_ids: list[int] = []
         for character in live_data.characters:
             live_character_ids.append(character.id)
-            cache.extras.get(str(character.id), {}).update(live_chara_data)
+            if str(character.id) not in cache.extras:
+                cache.extras[str(character.id)] = live_chara_data
+            else:
+                cache.extras[str(character.id)].update(live_chara_data)
 
         cache_characters_not_in_live: list["Character"] = []
 

diff --git a/src/hoyo/mihomo_client.py b/src/hoyo/mihomo_client.py
@@ -33,7 +33,10 @@ def _update_cache_with_live_data(
         live_character_ids: list[str] = []
         for character in live_data.characters:
             live_character_ids.append(character.id)
-            cache.extras.get(character.id, {}).update(live_chara_data)
+            if character.id not in cache.extras:
+                cache.extras[character.id] = live_chara_data
+            else:
+                cache.extras[character.id].update(live_chara_data)
 
         cache_characters_not_in_live: list["Character"] = []