Update atomic_queue to latest version #1248
Conversation
| // Implement a "bit-twiddling hack" for finding the next power of 2 | ||
| // in either 32 bits or 64 bits in C++11 compatible constexpr functions | ||
| // Implement a "bit-twiddling hack" for finding the next power of 2 in either 32 bits or 64 bits | ||
| // in C++11 compatible constexpr functions. The library no longer maintains C++11 compatibility. |
There was a problem hiding this comment.
My concern was this. I'll check but one of my personal targets used to have a C++11 limitation, which I think is lifted now.
There was a problem hiding this comment.
That being said, as far as I remember, the only issue was some multi-line constexpr functions which are just cosmetics. We could very well rewrite these as C++11 compatible constructs, which is what I did at the time but Maxim did not want to constrain his library in the end.
|
As explained in the comments I'll check my other toolchains as soon as I can. If we move forward, we also don't need to vendor this anymore. If it happens that the toolchain breaks, then I'll merge the compatibility bits and relevant changes in the vendored library so it'll still work out. Thanks a lot for the PR! |
This PR updates atomic_queue to the latest stable version, v1.6.1, which includes support for additional architectures, including RISC-V (fixes #1023) and PowerPC, allowing sfizz to be built on those architectures.