Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone sfizz using wrapper #848

Closed
wants to merge 1 commit into from

Conversation

jpcima
Copy link
Collaborator

@jpcima jpcima commented Apr 17, 2021

Standalone with JACK client and Editor

It's based on vst3 sample projects, namely audiohost and editorhost, which are dynamic-loading wrappers of the vst3 bundle.
For some unknown reason, sdk doesn't provide a 2-in-1 host program, so this is a large copy&paste to do just that.

Work in progress

  • segfaults on exit
  • selects to host in gtkmm rather than raw X11 (the latter has a crash issue, the former acts more sluggish)
  • uses a search for the vst3 bundle in standard paths, and also the host program's folder, to let it run from the build
  • possibly reveals an implementation bug in our vst3:
    it blocks sendMessage from our background thread, because it has a thread checker which rejects origins other than the UI thread. For example, the MIDI note events don't transfer to the visual keyboard. This maybe calls to reexamine the update model used in the processor.

@paulfd
Copy link
Member

paulfd commented Apr 20, 2021

  • it blocks sendMessage from our background thread, because it has a thread checker which rejects origins other than the UI thread. For example, the MIDI note events don't transfer to the visual keyboard. This maybe calls to reexamine the update model used in the processor.

Any reason for this limitation? Maybe the message pipe is an SPSC queue?

@jpcima
Copy link
Collaborator Author

jpcima commented Apr 20, 2021

Any reason for this limitation? Maybe the message pipe is an SPSC queue?

After researching this deeper, I arrived to the conclusion that it's probably just an unimplemented.

// TODO we should test if we are in UI main thread else postpone the message

At least one sample of vst3sdk calls sendMessage in a non-UI thread.

redtide added a commit to redtide/sfizz-ui that referenced this pull request Oct 23, 2023
Work started by @jpcima in sfztools/sfizz#848
adapted after repository split with newer VST3 SDK
@redtide
Copy link
Member

redtide commented Oct 23, 2023

Moved and updated in sfztools/sfizz-ui#105

@redtide redtide closed this Oct 23, 2023
redtide added a commit to redtide/sfizz-ui that referenced this pull request Oct 23, 2023
Work started by @jpcima in sfztools/sfizz#848
adapted after repository split with newer VST3 SDK
redtide added a commit to redtide/sfizz-ui that referenced this pull request Oct 23, 2023
Work started by @jpcima in sfztools/sfizz#848
adapted after repository split with newer VST3 SDK
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants