Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(example): add missing CommandList component to combobox-form #4067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

keremnalbant
Copy link

@keremnalbant keremnalbant commented Jun 21, 2024

fixes: #4061, #3976, #3907

what happened: with the new release of cmdk library, it is now mandatory to render the CommandList component.

https://github.com/pacocoursey/cmdk/releases/tag/v1.0.0

CleanShot 2024-06-21 at 14 48 57@2x
#4061 (comment)

see the recording of the issue:
0622

Copy link

vercel bot commented Jun 21, 2024

Someone is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@arganaphang
Copy link

duplicate PR? #4024

@keremnalbant
Copy link
Author

keremnalbant commented Jun 22, 2024

duplicate PR? #4024

yes... after creating the PR, i realized there is two more PRs fixes the same thing.

But, there are multiple issues created adressing the same problem. That pushed me to create a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: client side exception at combobox component
2 participants