Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Migrate Firefox from macos-13 to macos-latest #6853

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jun 18, 2024

Using arm (macos-latest) wherever possible reduces build times by 3 minutes.

We have a limited number of macos runners, so if we save time even on Firefox alone (all we can do pending #6508), we can speed up the queue of pending jobs across PRs.

@avelad avelad added the type: CI An issue with our continuous integration tests label Jun 18, 2024
@avelad avelad added this to the v4.10 milestone Jun 18, 2024
@avelad avelad changed the title ci: Migrate macos-13 to macos-latest ci: Migrate Firefox from macos-13 to macos-latest Jun 18, 2024
@avelad avelad requested a review from joeyparrish June 18, 2024 15:16
@shaka-bot
Copy link
Collaborator

Incremental code coverage: No instrumented code was changed.

@joeyparrish
Copy link
Member

It seems like there is not much point in migrating Firefox without migrating Chrome and Edge, since the build times for macos-13 Chrome and Edge will still dominate the overall test time. And we can't move those without solving #6508

@avelad
Copy link
Collaborator Author

avelad commented Jun 18, 2024

@joeyparrish Taking into account the number of executions there are, saving 3 minutes in each execution is a lot! even if it's just Firefox

@joeyparrish
Copy link
Member

I'm not sure what you mean. Are you saying that if we have to do a rerun, and that rerun doesn't include Chrome-Mac and Edge-Mac, we save 3 minutes on the rerun?

@avelad
Copy link
Collaborator Author

avelad commented Jun 18, 2024

In my tests we have a limited number of macos runners, so if we save time in this case, if there are many jobs in the queue, we can speed up the queue because this type of job lasts 3 minutes less. I don't find any problem in not merging this.

@joeyparrish
Copy link
Member

Ah, I see. I'll expand the description with this information, then approve and merge.

@joeyparrish joeyparrish merged commit e613972 into shaka-project:main Jun 18, 2024
17 of 18 checks passed
@avelad avelad deleted the ci-macos-latest branch June 19, 2024 05:37
avelad added a commit that referenced this pull request Jun 19, 2024
Using arm (macos-latest) wherever possible reduces build times by 3
minutes.

We have a limited number of macos runners, so if we save time even on
Firefox alone (all we can do pending #6508), we can speed up the queue
of pending jobs across PRs.
avelad added a commit that referenced this pull request Jun 19, 2024
Using arm (macos-latest) wherever possible reduces build times by 3
minutes.

We have a limited number of macos runners, so if we save time even on
Firefox alone (all we can do pending #6508), we can speed up the queue
of pending jobs across PRs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: CI An issue with our continuous integration tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants