Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(HLS): Allow disable initial variant if necessary #6940

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

avelad
Copy link
Collaborator

@avelad avelad commented Jun 28, 2024

This change allows us to detect when the initial variant fails (for example due to a 404, 503 in the m3u8 request) and we can change to another variant.

@avelad avelad requested a review from theodab June 28, 2024 13:18
@avelad avelad added type: bug Something isn't working correctly component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release labels Jun 28, 2024
@avelad avelad added this to the v4.10 milestone Jun 28, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 77.50%

@avelad avelad merged commit 3416054 into shaka-project:main Jun 29, 2024
18 of 19 checks passed
@avelad avelad deleted the hls-initial-disable-stream branch June 29, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: HLS The issue involves Apple's HLS manifest format priority: P1 Big impact or workaround impractical; resolve before feature release type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants