Skip to content

Commit

Permalink
linted webpacker spec
Browse files Browse the repository at this point in the history
  • Loading branch information
vaukalak committed Jul 1, 2024
1 parent 9d5e8c2 commit fa70185
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ Please follow the recommendations outlined at [keepachangelog.com](http://keepac
Changes since the last non-beta release.

#### Improved
- Improved dependency management by integrating package_json. [PR 1544](https://github.com/shakacode/react_on_rails/pull/1639) by [vaukalak](https://github.com/vaukalak).
- Improved dependency management by integrating package_json. [PR 1639](https://github.com/shakacode/react_on_rails/pull/1639) by [vaukalak](https://github.com/vaukalak).

### [14.0.3] - 2024-06-28

Expand Down
6 changes: 4 additions & 2 deletions rakelib/webpacker_examples.rake
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@ namespace :webpacker_examples do # rubocop:disable Metrics/BlockLength
bundle_install_in(example_type.dir)
sh_in_dir(example_type.dir, "rake webpacker:install")
shell_commands = []
shell_commands << "PACKAGE_JSON_FALLBACK_MANAGER=yarn_classic rails generate react_on_rails:install #{example_type.generator_options} --ignore-warnings --force"
shell_commands << "PACKAGE_JSON_FALLBACK_MANAGER=yarn_classic rails generate react_on_rails:dev_tests #{example_type.generator_options}"
env = "PACKAGE_JSON_FALLBACK_MANAGER=yarn_classic"
options = example_type.generator_options
shell_commands << "#{env} rails generate react_on_rails:install #{options} --ignore-warnings --force"
shell_commands << "#{env} rails generate react_on_rails:dev_tests #{options}"
sh_in_dir(example_type.dir, "yarn")
end
end
Expand Down

0 comments on commit fa70185

Please sign in to comment.