Refactor tests #135
Merged
Refactor tests #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…GE with UTEST_EXCEPTION_WITH_MESSAGE
|
This is a nice PR - I hadn't considered this, makes the library smaller, and you've been very respectful with how you proposed the change. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I recently added
EXPECT_EXCEPTION_WITH_MESSAGEandASSERT_EXCEPTION_WITH_MESSAGE, I noticed that tests need to be defined twice, once for "expect" and once for "assert". This PR is a refactor for using the same macros for tests and then defining "expect" and "assert" accordingly. Reduce theutest.hlength from 1715 lines to 1529 lines (~11% less).I made a commit for each test to make it easier to review.