Project directory cleanup #2134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This script is only executed by the GitHub workflow. Keeping it inside the scripts directory makes the project's directory cleaner. Additionally, it decreases the chance of contributers executing the script even though its harmless.
This was an example docker-compose.yml file. This example is also available in ./docs/INSTALL.md. So keeping the file is just redundant
ppfeister
requested changes
May 24, 2024
There was a problem hiding this comment.
Thoughts on /devel/ or similar rather than /scripts/?
Implies that whatever is contained shouldn't be relied upon at runtime or used by the normal user
Also, whatever the directory is named, can you include it in .dockerignore
I assume the relative path changes you made to site-list work, but this will likely break CI as well. Rel path in .github/workflows/update-site-list.yml should be updated to whatever the dir name is here.
|
@ppfeister The changes you have suggested have been made |
ppfeister
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up the project's directory to keep things tidy. More files will be removed once #2111 has been merged