Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed uneeded info from --version output #2151

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Removed uneeded info from --version output #2151

merged 1 commit into from
Jun 2, 2024

Conversation

sdushantha
Copy link
Member

@sdushantha sdushantha commented Jun 2, 2024 •
edited
Loading

Personally I'd rather want to see the version of Sherlock I am running and not the version of Python and requests. Thoughts?

Before

$ sherlock --version
sherlock 0.14.4
Python HTTP for Humans.:  2.32.3
Python:  3.12.3

After

$ sherlock --version            
Sherlock v0.14.4

@sdushantha sdushantha requested a review from ppfeister June 2, 2024 14:56
ppfeister
ppfeister reviewed Jun 2, 2024
View reviewed changes
Copy link
Member

@ppfeister ppfeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had considered making the same change in #2127 but figured they were there for a reason

That being said, I completely agree

@ppfeister ppfeister merged commit 3b187d1 into master Jun 2, 2024
3 checks passed
@sdushantha sdushantha deleted the cleaner-version-output branch June 2, 2024 19:23
ppfeister added a commit that referenced this pull request Jun 24, 2024
@ppfeister
Minor lint
402d7a1 
Fixes hanging imports from #2151
Fixes bare f-string from #2178
@ppfeister ppfeister mentioned this pull request Jun 24, 2024
Merged
ppfeister added a commit that referenced this pull request Jun 24, 2024
@ppfeister
Minor lint
c2805f8 
Fixes hanging imports from #2151
Fixes bare f-string from #2178
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppfeister ppfeister ppfeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdushantha @ppfeister