Introduction of --tag optional argument for tag handling

[Gregory-rt]

As mentioned in #2164, this pull request aims to introduce functionality in order to allow Sherlock to search through sites that other than a username need also a tag in order to identify an account. The solution proposed is an optional argument --tag which would allow the user to input that tag, a boolean tag_required and a # in the url of those sites. Given the argument tag sherlock will return all sites where tag_required is false/non existent replacing only the {} with the username, and those in which it is true it would also replace the # with the given tag.

If #2169 is merged, due to similarities this should be closed.

[roxerj]

With this functionality, you can't search for multiple usernames because only one tag is provided, while in #2169 you can search for multiple usernames e.g. sherlock sophie#1911 "normalus bahuras#euw" --tag
Also sherlock sophie --tag 1911 returns a lot of other results with a username "sophie" without a tag, and only one of them might be the one you're looking for, with a tag. "sophie" is a generic name so there are many unwanted results on various websites.

[Gregory-rt]

With this functionality, you can't search for multiple usernames because only one tag is provided, while in #2169 you can search for multiple usernames e.g. sherlock sophie#1911 "normalus bahuras#euw" --tag

That is correct, multiple tags are not supported with this implementation, although multiple usernames is supported (all are being searched with the tag given).

Also sherlock sophie --tag 1911 returns a lot of other results with a username "sophie" without a tag, and only one of them might be the one you're looking for, with a tag. "sophie" is a generic name so there are many unwanted results on various websites.

This was intended, with this implementation --tag allows you to broaden the sites pool, with the inclusion of sites that require a tag to be searched through. I didnt see it as a way to search through only those sites but a way to also search these sites.

[ppfeister]

Please reference #2169 (comment)