Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated docs to inlcude poetry to requirements.txt convertion #2173

Closed
wants to merge 1 commit into from
Closed

Updated docs to inlcude poetry to requirements.txt convertion #2173

wants to merge 1 commit into from

Conversation

sdushantha
Copy link
Member

fixes #2156

@ppfeister
Copy link
Member

I remember doing this locally, but I guess I forgot to push 😶

@ppfeister
Copy link
Member

I think it would go better moved up to immediately following the "Build live package from source (useful for contributors)" header, since building from source would also require it for some workflows

Agree/disagree?

@sdushantha
Copy link
Member Author

sdushantha commented Jun 17, 2024 •
edited
Loading

I agree, changes have been made accordingly

@sdushantha
Copy link
Member Author

Closing this as its been fixed in #2160

@sdushantha sdushantha closed this Jun 17, 2024
@ppfeister
Copy link
Member

huh... i guess i did pr it

and you even suggested changes

man, i've been out of it the last few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ppfeister ppfeister Awaiting requested review from ppfeister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Installation from sources
2 participants
@sdushantha @ppfeister