Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename importable module #2190

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Rename importable module #2190

wants to merge 3 commits into from

Conversation

ppfeister
Copy link
Member

Importable module name collides with that of another package on PyPI, causing issues downstream. This PR introduces parity between the standard package name and the module name, avoiding this collision, and meeting conventions.

In particular, this addresses blocking conflicts discussed in Debian #1071007 and #1072733.

This may be a breaking change for some end users, so it may be worth bumping the minor or patch number.

@ppfeister ppfeister added the enhancement New feature or request label Jun 24, 2024
@ppfeister ppfeister self-assigned this Jun 24, 2024
@ppfeister ppfeister marked this pull request as ready for review June 24, 2024 21:08
@ppfeister
Copy link
Member Author

ppfeister commented Jun 24, 2024

Tests are PASSING --- disregard errors.

Validation against remote schema fails before merge due to the file path change. This is expected.

Review changes but do not merge into master. Merge should be coordinated with other breaking changes and a minor/patch bump.

@ppfeister ppfeister added the do not merge Don't merge this PR label Jun 24, 2024
@ppfeister
Copy link
Member Author

Installable package remains sherlock-project. Importable module switched from sherlock to sherlock_project, with directory rename. Binary entry point remains sherlock.

@ppfeister ppfeister added staged - do not merge PR is staged for coordinated release and removed do not merge Don't merge this PR staged - do not merge PR is staged for coordinated release labels Jun 25, 2024
@ppfeister
Copy link
Member Author

Staged staging/0.15.0rc0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant