Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: various improvements for loading files, GH actions, linting, R CMD CHECK fixes #25

Merged
merged 12 commits into from
Apr 19, 2024

Conversation

m-jahn
Copy link
Collaborator

@m-jahn m-jahn commented Apr 13, 2024

  • LoadTrack function was refactored to remove code duplications (lapply + bplapply)
  • LoadTrack function has now NULL as default chromosome (fixes Non-eukaryotic data and input files? #9)
  • handles now binning for bam files regardless if done via bamCoverage or GenomicAlignments
  • various small linting fixes
  • added author to DESCRIPTION, bumbed Roxygen
  • refactored ggcoverage.Rmd and README.Rmd in order to remove all lint errors, adhere to R code style
  • added Github Actions workflow to automatically run R CMD CHECK for each commit and PR to dev/main

@m-jahn m-jahn requested a review from showteeth April 13, 2024 09:39
@m-jahn m-jahn self-assigned this Apr 13, 2024
@m-jahn m-jahn added the enhancement New feature or request label Apr 13, 2024
@m-jahn
Copy link
Collaborator Author

m-jahn commented Apr 15, 2024

@showteeth can you make a code review? Thanks!

@m-jahn
Copy link
Collaborator Author

m-jahn commented Apr 17, 2024

@showteeth this PR is ready. fixed many problems and included github actions workflow, with the result that the package now builds without errors on all major platforms, see automatic checks.

I suggest to bump the version of the package to 1.3.0 (minor release). There are no breaking changes as far as I can see.

@m-jahn m-jahn changed the title feat: various improvements for loading files feat: various improvements for loading files, GH actions, linting, R CMD CHECK fixes Apr 18, 2024
@m-jahn m-jahn merged commit d4f7f42 into showteeth:main Apr 19, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-eukaryotic data and input files?
1 participant