Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues #123 - #124 #172

Merged
merged 4 commits into from
Feb 20, 2022
Merged

Issues #123 - #124 #172

merged 4 commits into from
Feb 20, 2022

Conversation

isengu
Copy link
Contributor

@isengu isengu commented Dec 5, 2021

Hi, regarding to #123 and #124,

  • I updated themes file to allow gradient and image background values.
  • I updated layouts file to be compatible with the first one, because previously there are no # character in color values in themes file so it was being added automaticly in the layouts file assuming every color value is hex.
  • I updated structures of churchill and samuel layouts because they were not compatible with gradient and/or image backgrounds.

Here are examples:
linear-gredient
matrix-img-bg
matrix-default
samuel
gradient-samuel

@isengu
Readjustment of socrates layout
427d747
@isengu
Merge branch 'shravan20:main' into main
d37aaa8
@isengu
Merge branch 'shravan20:main' into main
4008665
@isengu
Themes file updated to allow not just hex values but also gradient an…
d918646 
…d url values. Layout file updated accordingly as well as churchill and samuel layouts structure readjusted because of not being useable other then solid color values. In addition, added two new themes for demonstration purpose of gradient and image backgrounds.
@shravan20
Copy link
Owner

@nishantpersonal : Kindly review the PR and check it
@dolmushcu : Will update you since there are few major changes, we will test and ensure existing functionalities are not affected

@shravan20 shravan20 added enhancement New feature or request hacktoberfest hacktoberfest-accepted Much work This task takes little time to complete. (ETA several weeks+) refactoring The changes in code without affecting functionality to improve the code labels Dec 6, 2021
@shravan20 shravan20 added this to the Release of V2.0 milestone Dec 22, 2021
@shravan20 shravan20 linked an issue Dec 22, 2021 that may be closed by this pull request
Create custom themes from Website itself #147
Open
@shravan20 shravan20 removed a link to an issue Dec 22, 2021
Create custom themes from Website itself #147
Open
This was linked to issues Dec 22, 2021
Implementation of Quote Card with [Background Image](https://codepen.io/governorfancypants/pen/elsDc) #123
Closed
Gradient Design Background for the Quote Card #124
Closed
@shravan20 shravan20 added this to In progress in Github Readme Quote Dec 22, 2021
shravan20
shravan20 approved these changes Feb 8, 2022
View reviewed changes
Copy link
Owner

@shravan20 shravan20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR LGTM

@shravan20 shravan20 merged commit d54a7d9 into shravan20:main Feb 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shravan20 shravan20 shravan20 approved these changes

@nishantpersonal nishantpersonal Awaiting requested review from nishantpersonal

Assignees

@isengu isengu

Labels
enhancement New feature or request hacktoberfest hacktoberfest-accepted Much work This task takes little time to complete. (ETA several weeks+) refactoring The changes in code without affecting functionality to improve the code
Projects
Github Readme Quote
In progress
Milestone
Release of V2.0
2 participants
@isengu @shravan20