Catch unsupported build mode passed to build.py #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When build.py is invoked with --build_only, it reuses the existing controller source code to build the docker image. This assumes that the necessary sieve instrumentation for building the controller in the specified mode is already present in the source tree. But this limits passing in 'ALL' mode to build.py to build all three controller image variants at the same time. Adding in code changes to throw an error in this case until this support is added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When build.py is invoked with --build_only, it reuses the existing controller source code to build the docker image. This assumes that the necessary sieve instrumentation for building the controller in the specified mode is already present in the source tree. But this limits passing in 'ALL' mode to build.py to build all three controller image variants at the same time. Adding in code changes to throw an error in this case until this support is added.