Add a macos platform tag in node image #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running kind on macOS with node image (that has Sieve instrumentation) built on a Linux machine is failing with errors - see https://gist.github.com/jerrinsg/578fa112c232a72360367300be563901. Building the node image locally on a Mac and using that image works though. This commit therefore adds a new "macos" platform tag to node image built for macOS so as to specifically use this image when running on Mac.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running kind on macOS with node image (that has Sieve instrumentation) built on a Linux machine is failing with errors - see https://gist.github.com/jerrinsg/578fa112c232a72360367300be563901. Building the node image locally on a Mac and using that image works though. This commit therefore adds a new "macos" platform tag to node image built for macOS so as to specifically use this image when running on Mac.