Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for configuration from yaml file #1687

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

javanlacerda
Copy link
Contributor

@javanlacerda javanlacerda commented Jun 5, 2024

Contribute towards #1111

Summary

It updates the logic to support configuration from yaml file. It will be useful for migrating the ci providers onboarding to filling a yaml file instead of creating new modules.

Release Note

Documentation

cc @haydentherapper

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 48.55%. Comparing base (cf238ac) to head (95e47f9).
Report is 108 commits behind head on main.

Files Patch % Lines
pkg/config/config.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1687      +/-   ##
==========================================
- Coverage   57.93%   48.55%   -9.39%     
==========================================
  Files          50       67      +17     
  Lines        3119     4043     +924     
==========================================
+ Hits         1807     1963     +156     
- Misses       1154     1864     +710     
- Partials      158      216      +58     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@javanlacerda javanlacerda changed the title Create support for configuration from yaml file Adding support for configuration from yaml file Jun 5, 2024
Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@haydentherapper haydentherapper merged commit ec3f4e5 into sigstore:main Jun 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants