Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds tolerations, nodeSelector, and affinity to scaffold. #763

Conversation

ianhundere
Copy link
Contributor

@ianhundere ianhundere commented May 24, 2024

Partly resolves #696

Description of the change

Adds tolerations, nodeSelector and affinity to charts.

Existing or Associated Issue(s)

Request for tolerations, nodeSelector and affinity to be allowed to configure for all charts

Additional Information

initial PR w/ all changes in one.

Checklist

  • Chart version bumped in Chart.yaml according to semver. Where applicable, update and bump the versions in any associated umbrella chart
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.
Linting charts...

------------------------------------------------------------------------------------------------------------------------
 Charts to be processed:
------------------------------------------------------------------------------------------------------------------------
 scaffold => (version: "0.6.51", path: "charts/scaffold")
------------------------------------------------------------------------------------------------------------------------

"sigstore" already exists with the same configuration, skipping
Hang tight while we grab the latest from your chart repositories...
...Successfully got an update from the "sigstore" chart repository
Update Complete. ⎈Happy Helming!⎈
Saving 6 charts
Downloading fulcio from repo https://sigstore.github.io/helm-charts
Downloading rekor from repo https://sigstore.github.io/helm-charts
Downloading trillian from repo https://sigstore.github.io/helm-charts
Downloading ctlog from repo https://sigstore.github.io/helm-charts
Downloading tuf from repo https://sigstore.github.io/helm-charts
Downloading tsa from repo https://sigstore.github.io/helm-charts
Deleting outdated charts
Linting chart "scaffold => (version: \"0.6.51\", path: \"charts/scaffold\")"
Checking chart "scaffold => (version: \"0.6.51\", path: \"charts/scaffold\")" for a version bump...
Old chart version: 0.6.50
New chart version: 0.6.51
Chart version ok.
Validating /Users/ianhundere/Desktop/helm-charts/charts/scaffold/Chart.yaml...
Validation success! 👍

Linting chart with values file "charts/scaffold/ci/ci-values.yaml"...

==> Linting charts/scaffold
[INFO] Chart.yaml: icon is recommended

1 chart(s) linted, 0 chart(s) failed

------------------------------------------------------------------------------------------------------------------------
 ✔︎ scaffold => (version: "0.6.51", path: "charts/scaffold")
------------------------------------------------------------------------------------------------------------------------
All charts linted successfully

cc @hectorj2f / @cpanato

@ianhundere
Copy link
Contributor Author

ianhundere commented May 24, 2024

will rebase once the following are merged:

@ianhundere ianhundere marked this pull request as ready for review June 12, 2024 13:04
@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_scaffold branch 2 times, most recently from a05bb59 to 5f786a4 Compare June 13, 2024 17:47
@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_scaffold branch 3 times, most recently from d5ea761 to 5cf5d2e Compare June 27, 2024 13:50
@ianhundere
Copy link
Contributor Author

ianhundere commented Jun 27, 2024

@cpanato went ahead and rebased this as well. cheers / thanks!

@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_scaffold branch from c342c16 to 9933978 Compare June 27, 2024 13:55
@ianhundere ianhundere force-pushed the adds_tolerations_nodeSelector_and_affinity_to_scaffold branch from 9933978 to 350380b Compare June 27, 2024 13:59
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@cpanato cpanato merged commit 2b2182e into sigstore:main Jul 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request for tolerations, nodeSelector and affinity to be allowed to configure for all charts
3 participants