Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the domains in fulcio config map to match each other #623

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

therealnb
Copy link
Contributor

Summary

This change is to address a startup issue in fulcio. See details at #622

Release Note

This is a small change of config. This looks like it might have been fixed twice because there are sections in the scripts like this

# Install Fulcio and wait for it to come up
echo '::group:: Install Fulcio'
if [ "${NEED_TO_UPDATE_FULCIO_CONFIG}" == "true" ]; then
  echo "Fixing Fulcio config"
  cp config/fulcio/fulcio/200-configmap.yaml ./200-configmap.yaml
  # The sed works differently in mac and other places, so just shuffle
  # files around for now.
  sed 's@https://kubernetes.default.svc.cluster.local@https://kubernetes.default.svc@' config/fulcio/fulcio/200-configmap.yaml > ./200-configmap-new.yaml
  mv ./200-configmap-new.yaml config/fulcio/fulcio/200-configmap.yaml
fi
make ko-apply-fulcio
echo '::endgroup::'

Where the change in this PR would be reverted for k8s < 1.24.

CC @vaikas

Signed-off-by: Nigel Brown <[email protected]>
@therealnb
Copy link
Contributor Author

Hmmm, different versions different behaviour. Needs investigation...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant