pre-commit and linters configuration #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simon-weber
reviewed
May 6, 2024
Comment on lines
+13
to
+14
| assert time | ||
| assert datetime |
There was a problem hiding this comment.
This is a little hack so the linter won't remove the imports, as it believes the module are not called in the file.
Actually there is a eval that does call them dynamically, so the asserts make the linter happy.
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a pre-commit configuration, with ruff, and applies it.
It also adds tox and GHA configuration to check the style is correct.
It removes remaining python 2 pieces of code, and comments.