Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openvla policy intergration #10

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

DelinQu
Copy link

@DelinQu DelinQu commented Jul 5, 2024

This pull request integrates openvla policy. The evaluation scripts remain consistent with the original repo under ./scripts/

@xuanlinli17
Copy link
Collaborator

Thanks for the contribution! Could you post the success rates for each task?

Could you post a source for the implementation of horizon, pred_action_horizon, exec_horizon, action ensemble, sticky gripper match, and do they match the real eval?

Code comments:

  • Remove " + OpenVLA policy" in readme
  • OpenVALInference -> OpenVLAInference
  • self.sticky_action_is_on is False in L147 of openvla_model.py: change to (not self.sticky_action_is_on)

@DelinQu
Copy link
Author

DelinQu commented Jul 6, 2024

Hi xuanlinli17, I have corrected all the typos. The implementation of horizon, pred_action_horizon, exec_horizon, action ensemble, etc., are migrating from octo. The evaluation results can be downloaded at
report_openvla.log

@xuanlinli17
Copy link
Collaborator

xuanlinli17 commented Jul 6, 2024

I see. Might want to get help from the official authors to validate / revise the implementation as the Bridge results are near zero for some reason, and pick coke can has large variance across different backgrounds. Additionally, it's possible that OpenVLA might not follow Octo implementation in real deployment.

@xuanlinli17
Copy link
Collaborator

xuanlinli17 commented Jul 6, 2024

Also you can modify https://github.com/simpler-env/SimplerEnv/blob/main/tools/calc_metrics_evaluation_videos.py to quickly summarize the results for OpenVLA (just put dummy numbers for the real numbers and don't push the script). You can ignore the nans.

@HuFY-dev
Copy link

HuFY-dev commented Jul 7, 2024

I'm also working on implementing OpenVLA into SimplerEnv, and I had the same issue: OpenVLA fails drastically on Bridge. I wonder if that has anything to do with the controller mentioned in #11

@sombitd
Copy link

sombitd commented Jul 8, 2024

Same here, Severe lack of performance of OpenVLA on WindowX robot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants