Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test wasn't relevant enough, this fix makes it much faster as well. #12

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AdrienLemaire
Copy link

Please notice that the Pypi version of django-longerusername is broken. Consider updating it, thanks

Please notice that the Pypi version of django-longerusername is broken. Consider updating it, thanks
@skoczen
Copy link
Owner

skoczen commented Mar 23, 2012

Pull requests that improve tests make me super-happy.

Could you actually add this as a second test instead of replacing the first? The original one is just testing that the monkeypatch didn't completely bork User. Yours does the relevant work of checking the length. Both are useful.

@skoczen
Copy link
Owner

skoczen commented Mar 23, 2012

Pypi: please use http://pypi.python.org/pypi/longerusername/

Someone else added django-longerusername, and I haven't been able to get in touch with him.

Edit: I was able to get in touch with the guy who added django-longerusername, and it's been pulled. Hooray for less confusion!

@matthanger
Copy link

I am said idiot. My apologies. I've removed the confusing pypi package.

Thanks so much for putting together a great and useful app.

@skoczen
Copy link
Owner

skoczen commented Mar 23, 2012

Matt -

Sorry for calling you an idiot. Edited this as soon as I heard from you. That was the "I saw this a few months ago and never took the time to google you down" frustration talking.

Thanks for your enthusiasm, and quick response in getting it cleared up!

@matthanger
Copy link

No worries. Thanks for calling me out/keeping me honest.

Fixes a few pep8 mistakes in the tests file
@AdrienLemaire
Copy link
Author

Done. You'll probably want to add a run_tests.py script to make it easy to verify the tests for this app. Also, your setup.py needs more informations, eg the python classifiers for better PyPI referencement.

Cheers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants