Skip to content
This repository has been archived by the owner on Oct 30, 2018. It is now read-only.

Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width #617

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

akievsk
Copy link

@akievsk akievsk commented Sep 3, 2017

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've been mindful about doing atomic commits, adding documentation to my changes, not refactoring too much.
  • I've a descriptive title and added any useful information for the reviewer. Where appropriate, I've attached a screenshot and/or screencast (gif preferrably).
  • I've written tests to cover the new code and functionality included in this PR.
  • I've read, agree to, and signed the Contributor License Agreement (CLA).

PR Summary

Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width

@dzenbot dzenbot changed the title Fixed placeholder label layout - it should calculate bounds consideri… Fixed placeholder label layout - it should calculate bounds considering label width, not bounds width Oct 26, 2017
@dzenbot
Copy link

dzenbot commented Nov 1, 2017

@akievsk did you find any ways to reproduce the issue on the sample project?
I haven't experienced any issues with the label. Even tho your changes seem logical, I would first want to verify the fix.

@akievsk
Copy link
Author

akievsk commented Nov 2, 2017

screen shot 2017-11-02 at 9 42 02 am
Here is the sample how this bug can be reproduced. I changed placeholder to something "very long" and changed height of text view to be more than one line

@dzenbot
Copy link

dzenbot commented Nov 2, 2017

Great. This is useful, thanks. Will review this soon.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants