Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Hack root in an arbitrary subdirectory #95

Closed
wants to merge 2 commits into from

Conversation

bigfootjon
Copy link

Closes: #94

This didn't end up being as easy as I hypothesized in the issue, but this seems like the best way to support a non-workspace root for Hack code.

@PranayAgarwal
Copy link
Member

I'm a bit hesitant to ship this because people have already complained about too many confusing path configurations in this extension, and this adds one more in the mix

package.json Outdated Show resolved Hide resolved
@bigfootjon
Copy link
Author

@PranayAgarwal, sorry this took me ~8 months to respond to your changes, I got sidetracked on other side projects :/

Please take another look when you get a chance

@bigfootjon
Copy link
Author

I no longer use HHVM so I'm going to close this

@bigfootjon bigfootjon closed this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Hack language server with .hhconfig not in root
2 participants