Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update progress.sh #154

Merged
merged 3 commits into from
Jul 26, 2024
Merged

Update progress.sh #154

merged 3 commits into from
Jul 26, 2024

Conversation

anacrolix
Copy link
Contributor

@anacrolix anacrolix commented Jul 24, 2024

Misc tweaks from banging my head while getting a node running locally.

@Chomtana
Copy link
Collaborator

So, this is mostly about syntax simplification, removing deprecated OP Goerli Testnet and typo fix right?

progress.sh main problem would be it can't work with snap sync

@anacrolix
Copy link
Contributor Author

Yeah I had issues running it due to cast missing, added set -e to catch that and discovered that the expr math caused it to fail if I had progressed no blocks. So I kept poking it until it ended up in the current state.

But also I didn't know that about the snap sync thing, that explains why I was getting no progress.

It's a pretty minor thing to change but it's more robust and useful than it was and saves someone else tripping on everything I did and ending up at the same place.

@Chomtana Chomtana merged commit c276ee1 into smartcontracts:main Jul 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants