Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Project None to int #165

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Conversation

perfectra1n
Copy link
Contributor

Perform Project data validation so that None is translate to int.

This solves the following error:

mashumaro.exceptions.InvalidFieldValue: Field "totalDependencies" of type int in Project has invalid value None

Perform Project data validation so that None is translate to int
@perfectra1n
Copy link
Contributor Author

This resolves #162.

@ujo-trackunit
Copy link

Would be nice to have this fixed.

@ebickle
Copy link

ebickle commented Jan 4, 2023

This is a blocker for our Snyk automation, which is failing due to snyk-labs/snyk-scm-refresh#125

Is there anything needed to get this PR reviewed and landed? This is a significant issue for us. Thanks!

@perfectra1n
Copy link
Contributor Author

@ebickle feel free to clone / fork my fork at https://github.com/perfectra1n/pysnyk if it makes any easier on you.

@abower-digimarc
Copy link

Would be nice to have this fixed. This is breaking snyk_scm_refresh for our org also.

@garethr
Copy link
Collaborator

garethr commented Jan 20, 2023

Apologies for the delay in reviewing. I'll look to add some tests for this change as well, but don't want to block merging. Thanks for the fix @perfectra1n

@garethr garethr merged commit f71b1a1 into snyk-labs:master Jan 20, 2023
lili2311 pushed a commit that referenced this pull request Oct 10, 2023
Resolve issue with type conversation between None and integer for number of dependencies
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants