Fix issue with limit duplication leading to errors #204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[this commit](dc75bc9) introduced a default limit in the client. However, the limit is also present in the URL. That leads to the 2nd and subsequent pages failing due to passing `limit=X&limit=X`. That is interpreted as an array by the server, and will fail with a client error. The fix checks the URL for the limit, and avoids the duplication if present.
lili2311
approved these changes
Oct 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this commit introduced a default limit in the client. However, the limit is also present in the URL. That leads to the 2nd and subsequent pages failing due to passing
limit=X&limit=X. That is interpreted as an array by the server, and will fail with a client error.The fix checks the URL for the limit, and avoids the duplication if present.