Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Project] Start dev phase v24.12 #4787

Merged
merged 8 commits into from
Jul 5, 2024
Merged

[Project] Start dev phase v24.12 #4787

merged 8 commits into from
Jul 5, 2024
+218 −2

Conversation

hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Jun 24, 2024 •
edited
Loading

This PR is a merge with #4802

  • New Changelog
  • Update CMake version
  • Fix Changelog with closed PR

close #4770

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jun 24, 2024
@hugtalbot hugtalbot requested a review from bakpaul June 24, 2024 12:56
@fredroy
Copy link
Contributor

fredroy commented Jun 25, 2024

Did you try to compile your own branch ? 😗 ... 😬

@fredroy
Copy link
Contributor

fredroy commented Jun 25, 2024

#4583

@hugtalbot hugtalbot added pr: status wip Development in the pull-request is still in progress and removed pr: status to review To notify reviewers to review this pull-request labels Jun 26, 2024
@fredroy fredroy mentioned this pull request Jul 2, 2024
Merged
@hugtalbot hugtalbot force-pushed the 202406_cherrypick_changelog_2406 branch from 8fd028f to 5895e94 Compare July 2, 2024 15:17
@hugtalbot
Copy link
Contributor Author

[ci-build][with-all-tests][force-full-build]

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request and removed pr: status wip Development in the pull-request is still in progress pr: fast merge Minor change that can be merged without waiting for the 7 review days labels Jul 2, 2024
fredroy
fredroy approved these changes Jul 3, 2024
View reviewed changes
Copy link
Contributor

@fredroy fredroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for #4802

@epernod epernod added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jul 3, 2024
@fredroy fredroy merged commit b679a97 into sofa-framework:master Jul 5, 2024
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredroy fredroy fredroy approved these changes

@bakpaul bakpaul Awaiting requested review from bakpaul

Assignees
No one assigned
Labels
pr: clean Cleaning the code pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hugtalbot @fredroy @epernod @bakpaul