Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Move ExampleVideo to MDXComponents #6145

Merged
merged 2 commits into from
Jul 1, 2024
Merged

docs: Move ExampleVideo to MDXComponents #6145

merged 2 commits into from
Jul 1, 2024

Conversation

patrycjakalinska
Copy link
Collaborator

Because ExampleVideo started to be widely used in documentations mdx, we moved it to MDXComponents.js to use it without further imports.

@patrycjakalinska patrycjakalinska marked this pull request as ready for review June 20, 2024 11:37
piaskowyk
piaskowyk approved these changes Jul 1, 2024
View reviewed changes
Copy link
Member

@piaskowyk piaskowyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it (both dev and production builds) and it seems to work fine. 👍

Additionally, I noticed that you don't need to import CollapsibleCode because it has already been exported in MDXComponents.js.

@patrycjakalinska patrycjakalinska added this pull request to the merge queue Jul 1, 2024
Merged via the queue into main with commit 4c4ec47 Jul 1, 2024
7 checks passed
@patrycjakalinska patrycjakalinska deleted the @patrycjakalinska/move-ExampleVideo branch July 1, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@piaskowyk piaskowyk piaskowyk approved these changes

@kacperkapusciak kacperkapusciak Awaiting requested review from kacperkapusciak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@patrycjakalinska @piaskowyk