Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PyTorch model reader. #1114

Merged
merged 5 commits into from
Jun 23, 2024
Merged

Refactor PyTorch model reader. #1114

merged 5 commits into from
Jun 23, 2024

Conversation

elad-c
Copy link
Collaborator

@elad-c elad-c commented Jun 19, 2024

Pull Request Description:

Refactor includes:

  1. remove duplication of framework_attr and node.kwargs in FunctionalNodes
  2. reorder graph_builders.py
  3. fix substitutions following the above changes

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

1. remove duplication of framework_attr and node.kwargs in FunctionalNodes
2. reorder graph_builders.py
3. fix substitutions following the above changes
@elad-c elad-c merged commit 3307fd0 into main Jun 23, 2024
27 checks passed
@elad-c elad-c deleted the refactor_torch_model_reader branch June 23, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in reading Tensors that enter nodes as kwargs
2 participants