Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename hessian service components #1124

Merged
merged 4 commits into from
Jul 8, 2024

Conversation

reuvenperetz
Copy link
Collaborator

Pull Request Description:

This PR renames components in the Hessian service to replace the term "trace," as it inaccurately represents per-element scores. This change aims to improve readability and maintainability by using more accurate and descriptive names.

Checklist before requesting a review:

  • I set the appropriate labels on the pull request.
  • I have added/updated the release note draft (if necessary).
  • I have updated the documentation to reflect my changes (if necessary).
  • All function and files are well documented.
  • All function and classes have type hints.
  • There is a licenses in all file.
  • The function and variable names are informative.
  • I have checked for code duplications.
  • I have added new unittest (if necessary).

@reuvenperetz reuvenperetz merged commit 71c2549 into sony:main Jul 8, 2024
29 checks passed
@reuvenperetz reuvenperetz deleted the rename-hessian-service branch July 8, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants