Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new design #33

Merged
merged 12 commits into from
May 31, 2018
Merged

added new design #33

merged 12 commits into from
May 31, 2018

Conversation

tridip1931
Copy link
Member

@tridip1931 tridip1931 commented May 13, 2018

Next Actions

@tridip1931 tridip1931 requested a review from geohacker May 13, 2018 13:39
@tridip1931 tridip1931 mentioned this pull request May 13, 2018
@tridip1931
Copy link
Member Author

tridip1931 commented May 13, 2018

  • Fix responsive breakage

@geohacker
Copy link
Member

@tridip1931 apologies for the delay on this one. I've been away. I really like this approach 👍. Will push copy changes just now and apart from the feedback Tejas has #32 (comment) this is good to go.

@jinalfoflia
Copy link
Collaborator

@jinalfoflia to give content on past SOTM

Pardon me for the delay @tridip1931, will take a stab on the content by Friday.

@tridip1931 tridip1931 changed the title [WIP: Do not merge] added new design added new design May 30, 2018
@geohacker
Copy link
Member

geohacker commented May 30, 2018

@tridip1931 thank you for your fixes. Here're few things we should do to get this MVP live:

  • Make the CoC page follow the same design - background, header etc.
  • Change 'Join us in Bangalore' card to may be the latest blog post? Or just hide it but we should keep the column without breaking
  • Change 'Apply for Scholarships' card to 'Scholarships applications are closed now.' and remove the link.
  • In the 'become a partner' section, change 'Learn more' button to 'Download sponsorship prospectus'.
  • Remove the 'Learn more' button in the venue section
  • Update link for twitter on in the footer. Remove links to blog and CoC in the footer.
  • Change 'Buy tickets' to 'Follow us' and link to twitter for now
  • Link last years report in the 2017 section

@tridip1931
Copy link
Member Author

Did a new thing here @geohacker
Instead of assigning a whole page for coc which comprises of only texts, I decided to show them on a modal.

Let me know if it does not work for you. The rationale behind this is I am following general UI pattern of how TOS are displayed.

@geohacker
Copy link
Member

Instead of assigning a whole page for coc which comprises of only texts, I decided to show them on a modal.

I'm ok with this, but I do think it's useful to have the CoC as a page which we can link to. I just made the modal wide and added a bit more padding. If you have time we should try to keep it as a page that's consistent with rest of the site.

@tridip1931 I also noticed that the CSS I added to main.css got overridden in your last commit - do you have a build process or are all the source files committed?

I added an app.css to override some of the bootstrap css.

@geohacker
Copy link
Member

I'm going to merge this @tridip1931. This looks like a good time to get the new design out. Thank you for all your work! 🙇

@geohacker geohacker merged commit d0e083a into master May 31, 2018
@geohacker geohacker deleted the new-design branch May 31, 2018 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants