refactor: make pippenger_multiproduct_solver generic ( PROOF-641 ) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnburn
approved these changes
Sep 18, 2023
jacobtrombetta
deleted the
refactor/make-pippenger_multiproduct_solver-generic-PROOF-641
branch
|
🎉 This PR is included in version 0.2.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The
pippenger_multiproduct_solvercomponent is currently part of themultiexp/curve21package. This is one PR in an effort to rework the multi-exponentiation code to be more generic so that we can support multiple curves without a bunch of duplicated code. This involves moving the code to themultiexp/curvepackage and using the element concept found in thebase/curvepackage.What changes are included in this PR?
pippenger_multiproduct_solvercomponent is rewritten to be generic.Are these changes tested?
Yes, from previous tests.