Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix tests (PROOF-620) #20

Merged
merged 1 commit into from
Sep 22, 2023
Merged

build: fix tests (PROOF-620) #20

merged 1 commit into from
Sep 22, 2023

Conversation

rnburn
Copy link
Collaborator

@rnburn rnburn commented Sep 21, 2023

Rationale for this change

In switching to clang, I missed an option in the build that is skipping all of the tests.

What changes are included in this PR?

  • Add missing alwayslink option so that tests can run
  • Fix a warning that clang gives.

Are these changes tested?

Yes.

@rnburn rnburn changed the title build: fix test (PROOF-620) build: fix tests (PROOF-620) Sep 21, 2023
Copy link
Contributor

@jacobtrombetta jacobtrombetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rnburn rnburn merged commit 374209b into main Sep 22, 2023
5 checks passed
@rnburn rnburn deleted the test-fix branch September 22, 2023 15:45
@SxT-Release
Copy link

🎉 This PR is included in version 0.2.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants