Bug fix for asdf cutouts with data as astropy quantity #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #114 +/- ##
==========================================
+ Coverage 94.56% 94.58% +0.01%
==========================================
Files 9 9
Lines 1472 1477 +5
==========================================
+ Hits 1392 1397 +5
Misses 80 80 ☔ View full report in Codecov by Sentry. |
dr-rodriguez
approved these changes
Jan 19, 2024
falkben
reviewed
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug in the asdf cutout code when the input data to the cutout was an Astropy Quantity instead of a straight numpy array. Now it accepts both and converts to a data array when writing out to the fits file.
It also now allows for the return of the cutout object for inspection.