-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error handling for CubeFactory
and TicaCubeFactory
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #85 +/- ##
==========================================
+ Coverage 93.78% 94.40% +0.61%
==========================================
Files 8 8
Lines 1416 1429 +13
==========================================
+ Hits 1328 1349 +21
+ Misses 88 80 -8
☔ View full report in Codecov by Sentry. |
falkben
reviewed
Jul 14, 2023
hmlewis-astro
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently the errors that get returned when SPOC FFIs are fed into
TicaCubeFactory
and vice versa are vague and not helpful to the user. This PR updates the error handling by raising an error when the wrong type of FFI is fed into eitherCubeFactory
orTicaCubeFactory
to make TESS cubes.Task List
CubeFactory
error handlingTicaCubeFactory
error handlingScreenshots (as of July 14, 2023)
The following two screenshots show the error that gets thrown when feeding the wrong type of FFI to
CubeFactory
andTicaCubeFactory
: