Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for CubeFactory and TicaCubeFactory #85

Merged
merged 12 commits into from
Jul 18, 2023
Merged

Conversation

jaymedina
Copy link
Collaborator

@jaymedina jaymedina commented Jul 14, 2023

Summary

Currently the errors that get returned when SPOC FFIs are fed into TicaCubeFactory and vice versa are vague and not helpful to the user. This PR updates the error handling by raising an error when the wrong type of FFI is fed into either CubeFactory or TicaCubeFactory to make TESS cubes.


Task List

  • Update CubeFactory error handling
  • Update TicaCubeFactory error handling
  • Add unit test(s)

Screenshots (as of July 14, 2023)

The following two screenshots show the error that gets thrown when feeding the wrong type of FFI to CubeFactory and TicaCubeFactory:

image image

@jaymedina jaymedina added the enhancement New feature or request label Jul 14, 2023
@jaymedina jaymedina self-assigned this Jul 14, 2023
@codecov
Copy link

codecov bot commented Jul 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.61 🎉

Comparison is base (311488d) 93.78% compared to head (fe01032) 94.40%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
+ Coverage   93.78%   94.40%   +0.61%     
==========================================
  Files           8        8              
  Lines        1416     1429      +13     
==========================================
+ Hits         1328     1349      +21     
+ Misses         88       80       -8     
Impacted Files Coverage Δ
astrocut/cube_cut.py 98.93% <100.00%> (+0.28%) ⬆️
astrocut/make_cube.py 94.15% <100.00%> (+1.75%) ⬆️

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jaymedina jaymedina marked this pull request as draft July 14, 2023 18:35
setup.cfg Outdated Show resolved Hide resolved
astrocut/make_cube.py Outdated Show resolved Hide resolved
@jaymedina jaymedina marked this pull request as ready for review July 15, 2023 18:43
@jaymedina jaymedina merged commit f0b4c45 into main Jul 18, 2023
8 checks passed
@jaymedina jaymedina deleted the error-handling branch July 18, 2023 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants