Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old bbox support #458

Merged
merged 1 commit into from
Jun 22, 2023
Merged

Conversation

Cadair
Copy link
Collaborator

@Cadair Cadair commented Jun 20, 2023

This is the first split out from #457

Given we recently bumped the Astropy version to 5.3 we presumably don't need this any more.

@Cadair Cadair requested a review from a team as a code owner June 20, 2023 14:26
@codecov
Copy link

codecov bot commented Jun 20, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.35 🎉

Comparison is base (e7056a9) 86.89% compared to head (bb1e5f3) 87.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #458      +/-   ##
==========================================
+ Coverage   86.89%   87.25%   +0.35%     
==========================================
  Files          23       23              
  Lines        3846     3820      -26     
==========================================
- Hits         3342     3333       -9     
+ Misses        504      487      -17     
Impacted Files Coverage Δ
gwcs/wcs.py 88.89% <100.00%> (+1.21%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Collaborator

@nden nden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nden
Copy link
Collaborator

nden commented Jun 22, 2023

Failure unrelated

@nden nden merged commit 8ded81c into spacetelescope:master Jun 22, 2023
@nden nden added this to the 0.19 milestone Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants