-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow splitting Celestial axes #467
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #467 +/- ##
==========================================
+ Coverage 87.23% 87.24% +0.01%
==========================================
Files 23 23
Lines 3815 3818 +3
==========================================
+ Hits 3328 3331 +3
Misses 487 487
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for decoupling this from #457!
@@ -521,3 +521,22 @@ def test_coordinate_frame_api(): | |||
|
|||
pixel2 = wcs.invert(world) | |||
assert u.allclose(pixel2, 0*u.pix) | |||
|
|||
|
|||
def test_split_celestial_axes(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add a test for this for not-quantity?
Curiously this seems to have not fixed the issue with my real production WCSes 🤔 |
ok, more specifically, it works with |
|
Close this in favour of #457 ? |
Closes #455
This fixes a problem with evaluating the backwards transform when a
CompositeFrame
contains aCelestialFrame
with non-consecutive axes.