Register empty 1.0.0 extension to avoid warning when opening old files #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
braingram
changed the title
braingram
changed the title
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
jwst tests passed except for the expected 5x errors due to unreleased changes in stcal (see spacetelescope/jwst#7874) |
|
roman regtests show only errors related to missing webbpsf data (see spacetelescope/romancal#794): |
|
p.s. UnboundLocalError -- Wow, how did this get merged and not caught in CI first? |
|
Another jwst regtest run with expected failures: https://plwishmaster.stsci.edu:8081/job/RT/job/JWST-Developers-Pull-Requests/948/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #473 for more details.
Changes in #469 removed the
1.0.0extension (which contains erroneous duplicate tags). A consequence of this removal is that opening old files produced with this extension results in the following warning:Based on discussions linked in #473 these warnings should be ignored (as the
1.0.1and1.1.0extensions support all the1.0.0tags). Rather than describe this nuance in the documentation and request that users update files this PR takes the alternative approach proposed in #473 to register an empty extension for the1.0.0uri (which does not use the1.0.0manifest). This prevents the above warning without requiring the user to update their files (this does mean that old files will continue to have the1.0.0extension listed in the asdf history, a test was added to verify that the changes in this PR are sufficient to allow opening of those files without a warning).Fixes #473