Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility with numpy 2.0 #510

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

mcara
Copy link
Member

@mcara mcara commented Sep 9, 2024

Fixes deprecation warnings related to computing cross product of 2D vectors using numpy.cross with numpy >= 2.0.

@mcara mcara self-assigned this Sep 9, 2024
@mcara mcara requested a review from a team as a code owner September 9, 2024 05:01
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.28%. Comparing base (eb9d316) to head (c58b4db).
Report is 12 commits behind head on master.

Files with missing lines Patch % Lines
gwcs/region.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #510      +/-   ##
==========================================
- Coverage   87.28%   87.28%   -0.01%     
==========================================
  Files          22       21       -1     
  Lines        3821     3813       -8     
==========================================
- Hits         3335     3328       -7     
+ Misses        486      485       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcara mcara requested a review from nden September 9, 2024 05:13
@mcara mcara force-pushed the fix-np2-deprecation-warning branch from db44021 to 2b4db29 Compare September 9, 2024 05:20
@nden nden modified the milestone: 0.22 Sep 16, 2024
@nden nden merged commit 506745b into spacetelescope:master Sep 16, 2024
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants