filter thumbnails by filter/pupil/grating #1623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @BradleySappington, Thank you for updating ! Cheers ! There are no PEP8 issues in this Pull Request. 🍻 Comment last updated at 2024-07-22 14:58:07 UTC |
|
|
@bhilbert4 @mfixstsci - Ready for Review |
mfixstsci
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Looks good to me @BradleySappington and with @bhilbert4 saying the changes looked good locally. I will approve and update the branch and get this in!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created filters for "filter", "pupil", and "grating"
These filters will be populated for all results on the following pages
query results
observation archive pages
Default values will be populated ONLY with those relevant to what is available to be filtered. This does mean that some dropdowns will only have one option, and in some cases, that option may be "empty".
I also aligned non-filtering dropdowns in a following horizontal rule section to avoid page real estate congestion.
https://jira.stsci.edu/browse/JWQL-202
closes #1573