-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RCAL-905: Add ePSF, ABVegaOffset, and ApCorr Datamodels #393
base: main
Are you sure you want to change the base?
Conversation
for more information, see https://pre-commit.ci
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #393 +/- ##
==========================================
+ Coverage 97.56% 97.75% +0.19%
==========================================
Files 30 37 +7
Lines 2788 3471 +683
==========================================
+ Hits 2720 3393 +673
- Misses 68 78 +10 ☔ View full report in Codecov by Sentry. |
…uwe/roman_datamodels into RCAL_905-PSFetalDataModels
RCAL regression tests: https://github.com/spacetelescope/RegressionTests/actions/runs/11097495928 |
epsfref["meta"] = mk_ref_epsf_meta(**kwargs.get("meta", {})) | ||
|
||
epsfref["psf"] = kwargs.get("psf", np.zeros(shape, dtype=np.float32)) | ||
epsfref["extended_psf"] = kwargs.get("extended_psf", np.zeros(shape[2:], dtype=np.float32)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left most of the relevant comments in the rad PR; this all looks good. But one dumb comment here: in the actual files, is the extended_psf shape actually the same as in the psf stamps, or significantly larger? I hope larger, even if we don't do that for the dummy epsf objects?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one sample file I have does not include the extended_psf
(it is an optional array keyword). By default, the maker utility just uses a dummy shape and is not representative of reality.
Resolves RCAL-905
Closes #905
This PR adds datamodels and tests for ePSF, ABVegaOffset, and ApCorr reference files. Other tests were tweaked for this support. The PR template was also updated to match the one from the RAD library.
Tasks
docs/
pageno-changelog-entry-needed
)changes/
:echo "changed something" > changes/<PR#>.<changetype>.rst
(see below for change types)romancal
regression test with this branch installed ("git+https://github.com/<fork>/roman_datamodels@<branch>"
)news fragment change types...
changes/<PR#>.feature.rst
: new featurechanges/<PR#>.bugfix.rst
: fixes an issuechanges/<PR#>.doc.rst
: documentation changechanges/<PR#>.removal.rst
: deprecation or removal of public APIchanges/<PR#>.misc.rst
: infrastructure or miscellaneous change