Add git sync v4 #23
Merged
Add git sync v4 #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r overriding file's original exec perms from repo.
…ience-platform-images into update-git-sync-v3
suffix and prefix parameters in favor of just spelling it out on the CLI. Added SYNC-INSTRUCTION updates from Thomas D and msanchez. Reversed parameter order in git-sync-v4 CLI for backwards compatibility. Added SYNC-INSTRUCTIONS.md to references/repo_dir/.. (i.e. references/)
chilly builds for now if only as a matter of form.
frozen builds need to happen on AWS anyway and if changes don't include frozen updates they're not correctly tested on GitHub at merge time.
it was making the build fail and (b) docker-stacks diligently clear caches making where they're stored irrelevant; in the case of our caches cache cleaning is currently turned off.
enabled status checking universally for git-sync-v4, both code and tests.
unusable and we need to revert to manual cache clearing.
…-o pipefail' to demo correct handling of multi-line scripts failing mid-way. Removed unused debug code which printed all results/error status for shell() even when check=False.
msanchezst
previously approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a 4th independent git-sync rewrite which has the same general strategy of v2 and v3 where clone directories are kept r/w for notebook execution but files/notebooks are locked down as readonly to discourage direct use for development. Major aspects of the rewrite are to switch to Python, add unit tests, and to attempt to differentiate between user-owned/modified files and git-owned files to avoid altering user files, even file perms. Also attempts to directly communicate with users using a SYNC-INSTRUCTIONS.md file to explain intended usage, and provides an opt-out mechanism for e.g. TIKE users who don't care about updates. Also stops using default repo names and moves all clones to a references/ directory. Affects all missions, all post-start-hooks updated with the intent that most failures cannot block logins, with EFS quota violations being the one failure I recall that can block logins. Also adds a gs4.fail.log file to the repo directory, assuming the repo dir exists but the sync failed hard for some reason; deleted for successful syncs.