Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle run cache mounts #5

Merged
merged 2 commits into from
Aug 9, 2023
Merged

Handle run cache mounts #5

merged 2 commits into from
Aug 9, 2023

Conversation

jaytmiller
Copy link
Collaborator

  • Ensure Docker RUN cache mount directories are created before being used in the build for caching
  • Ensure Docker RUN cache mounts for user caches remain user owned after the build; being used as a RUN cache results in the cache being a root-owned mount point until corrected. Cannot be corrected while mounted so a separate Dockerfile with no RUN caching is needed to restore directory ownership. Attempts to use uid/gid mount parameters failed.
  • Simplify image ID handling and make IDs disjoint from other science-platform git repos; this prevents science-platform-images from overwriting custom AWS IDs needed to push to ECR.

@jaytmiller
Draft changes to handle restoring writability to RUN cache directories
926891a
@jaytmiller
Image ID cleanup
ec7250b 
Dropped IMAGE_ID, COMMON_ID, IMAGE_TAG, COMMON_TAG, IMAGE_REPO, COMMON_REPO
  to avoid conflicts with setup-env-ssm and pipeline variations of same.
Added NOTEBOOK_ID and NOTEBOOK_TAG as replacements for IMAGE_xxx.
Modified scripts to use NOTEBOOK_ID vs. IMAGE_ID.
@jaytmiller
Copy link
Collaborator Author

  • Security scan failures are due to an unrelated vulnerability in the certifi package which should not block this PR.
  • Code quality is passing.
  • Image building failed for Roman but passed for Jwebbinar and TIKE. It's failing very early in the build process, during or immediately after the image pull of jupyter/docker-stacks... which did not fail for the other two different missions suggesting that the problem is not generic or related to these changes.

@jaytmiller jaytmiller merged commit 5a70edd into spacetelescope:main Aug 9, 2023
5 of 9 checks passed
@jaytmiller jaytmiller deleted the handle-run-cache-mounts branch August 9, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jaytmiller