Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation #166

Closed
wants to merge 0 commits into from
Closed

Fix deprecation #166

wants to merge 0 commits into from

Conversation

AlexKurek
Copy link
Contributor

No description provided.

@AlexKurek AlexKurek requested a review from a team as a code owner July 11, 2024 16:07
Copy link
Collaborator

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 58.35%. Comparing base (e074807) to head (a2c3088).
Report is 3 commits behind head on main.

Files Patch % Lines
src/stpipe/cli/command.py 33.33% 4 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #166       +/-   ##
===========================================
- Coverage   69.83%   58.35%   -11.49%     
===========================================
  Files          24       24               
  Lines        1618     1621        +3     
===========================================
- Hits         1130      946      -184     
- Misses        488      675      +187     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/stpipe/cli/command.py Outdated Show resolved Hide resolved
src/stpipe/cli/command.py Outdated Show resolved Hide resolved
src/stpipe/cli/command.py Outdated Show resolved Hide resolved
@zacharyburnett
Copy link
Collaborator

sorry for the miscommunication! you should still include @abc.abstractmethod, like this:

@abc.abstractmethod
@classmethod

@AlexKurek
Copy link
Contributor Author

sorry for the miscommunication! you should still include @abc.abstractmethod, like this:

@abc.abstractmethod
@classmethod

Ok, I get it now, done.

@zacharyburnett
Copy link
Collaborator

I apologize, I appear to have pushed away your fork's branch by accident. I remade this pull request at #167 with your commits

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants