Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

del model in map_function #181

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

braingram
Copy link
Collaborator

This PR makes a minor change to AbstractModelLibrary.map_function to reduce memory usage. More details can be found in the issue but the tldr is that this prevents having 2x models in memory during map_function.

Fixes: #173

@braingram braingram marked this pull request as ready for review August 7, 2024 13:07
@braingram braingram requested a review from a team as a code owner August 7, 2024 13:07
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.29%. Comparing base (b66eb3f) to head (5efae61).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   73.27%   73.29%   +0.01%     
==========================================
  Files          25       25              
  Lines        1916     1917       +1     
==========================================
+ Hits         1404     1405       +1     
  Misses        512      512              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@braingram braingram merged commit e11f835 into spacetelescope:main Aug 7, 2024
15 of 17 checks passed
@braingram braingram deleted the del_model branch August 7, 2024 13:19
@braingram
Copy link
Collaborator Author

Thanks! The romancal failure is due to the unrelated background schema changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicitly del model in ModelLibrary.map_function
2 participants