Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unsupported system_packages RTD config setting #361

Merged
merged 2 commits into from
Sep 6, 2023

Conversation

zacharyburnett
Copy link
Contributor

@zacharyburnett zacharyburnett commented Sep 6, 2023

Description

RTD no longer supports any system_packages setting: https://blog.readthedocs.com/drop-support-system-packages/

This PR removes the unused system_packages setting

RTD no longer supports any `system_packages` setting:
https://blog.readthedocs.com/drop-support-system-packages/

This PR removes the unused `system_packages` setting
@github-actions github-actions bot added the docs label Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thank you for your contribution! 🌌 This checklist is meant to remind the package maintainers who will review this pull request of some common things to look for.

  • Do the proposed changes actually accomplish desired goals?
  • Do the proposed changes follow the STScI coding guidelines?
  • Are tests added/updated as required? If so, do they follow the STScI testing guidelines?
  • Are docs added/updated as required?
  • Is rebase and/or squash necessary? If so, please provide the author with appropriate instructions.
  • Did the CI pass? If no, are the failures related?
  • Is a change log needed?
  • Is a milestone set? Milestone must be set but we cannot check for it on Actions; do not let the green checkmark fool you.

@github-actions
Copy link

github-actions bot commented Sep 6, 2023

👋 Thank you for your draft pull request! Do you know that you can use [ci skip] or [skip ci] in your commit messages to skip running continuous integration tests until you are ready?

@zacharyburnett zacharyburnett marked this pull request as ready for review September 6, 2023 15:22
@pllim pllim added this to the 1.3.0 milestone Sep 6, 2023
Copy link
Contributor

@pllim pllim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pllim pllim merged commit 3f593fd into spacetelescope:master Sep 6, 2023
8 checks passed
@zacharyburnett zacharyburnett deleted the patch-1 branch September 6, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants