Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving #272 & #270 (Missing directory structure) #277

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

P4jMepR
Copy link

@P4jMepR P4jMepR commented Jun 30, 2024

Pull Request Title

File structure missing. None of builds working correctly.

Related Issue

#272 & #270

Description

/Data/Processed directory (and it's content) were missing which caused the whole repo to be unusable "out-of-the-box" unless a structure was reconstructed.

  • I've modified .gitignore, but that did not help much (there has to be files inside of a directory for Git to recognize it). So I've decided to create a structure from codes perspective.
  • Relative pathing (Linux and Windows friendly) has been introduced in run_first.py
  • Modifed error logs in run_first.py to be more descriptive.

Type

  • Bug Fix
  • Feature Enhancement
  • Documentation Update
  • Code Refactoring
  • Other (please specify):

Proposed Changes

Listed already

Screenshots / Code Snippets (if applicable)

How to Test

Now code pulled from repo (both Docker & env) is even able to run without errors (out of the box).

Checklist

  • The code compiles successfully without any errors or warnings
  • The changes have been tested and verified
  • The documentation has been updated (if applicable)
  • The changes follow the project's coding guidelines and best practices
  • The commit messages are descriptive and follow the project's guidelines
  • All tests (if applicable) pass successfully
  • This pull request has been linked to the related issue (if applicable)

Additional Information

DOCKER_ERROR ENV_ERROR

As in title:
- Static pathing -> Relative pathing (in run_first.py)
- previous .gitignore structure messed up directory structure (srbhr#272)
Git won't acknowledge directories without any files within them.
Now if file structure is not complete it will create one. (solved srbhr#272)
@P4jMepR P4jMepR changed the title Solving #272 (Missing directory structure) Solving #272 & #270 (Missing directory structure) Jun 30, 2024
@srbhr
Copy link
Owner

srbhr commented Jun 30, 2024

Thanks @P4jMepR for this PR. I'm testing it out.

@srbhr
Copy link
Owner

srbhr commented Jun 30, 2024

Okay, there's a problem with how the files are being processed.
I'm already working on a major update for this @P4jMepR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants